Follow-up Comment #1, patch #1154 (project wesnoth):
Overall, the patch looks good.
There is one point that I definitely reject though. You shouldn't have to
include gettext, neither in filesystem.cpp nor in image.cpp. The language
code is already known by the engine (and if it doesn't always work, we have
to fix it), no need to add this dumb "language code for localized
resources^en_US" string.
Another detail, hardly important: Could you come with a better suffix than
"--ovr"? It doesn't really convey its meaning.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1154>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
