Follow-up Comment #2, patch #1610 (project wesnoth):
Thanks for looking at this.
* Comments: will fix in revision.
* choice_string: will return const char * in revision.
* The unit functions need not fatten the unit interface; a better solution
in my opinion is to make unit_helper.{c,h}pp with a unit_helper namespace. In
any case, fat files and fat interfaces only get fatter if you keep dumping in
them. This upload was mostly to show the shape of the solution rather than in
any way claimed as complete.
* classify_interactive_choice: I agree, there is an OOS that can be caught
earlier. It will be caught anyway though because if the replay is at end, an
OOS for "expecting choice" will be thrown. I'm not sure if it's desirable to
catch it earlier or not - does it substantially improve the error message we
can offer or not?
* I don't see the need to break in preload in game_has_started. The situation
will be classified as SYNCED, so it's safe to carry on processing. If the
action itself makes no sense in preload, that should be determined on a
per-action basis I think.
* I need to think about the right way to handle text, but my goal for this
patch was to fix bug #15560, which does not require text.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1610>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
