Update of patch #1640 (project wesnoth):
Status: None => In Progress
_______________________________________________________
Follow-up Comment #1:
ok, comments on the overall patches
* please add a changelog entry
* please add yourself to about.cfg if you're not in there yet
* please document in the wiki once I commit the patch
and now to the code
* you divide before multiplying when calculating with percentages. moreover
you manipulate int, so the loss of precision is quite important
* you directly change the user preferences which is bad, since the volume
change should be scenario specific. You need to track the volume and only set
it temporarly. my advice would be to attach the volume to whatever playlist
management code is in there. You could even improve your code for the volume
change to only last for the current sont or stay forever...
thx for the patch
Boucman
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1640>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
