URL:
<http://gna.org/bugs/?19121>
Summary: GUI2: automatic Close button in click_dismiss=true
dialogs doesn't do anything
Project: Battle for Wesnoth
Submitted by: shadowmaster
Submitted on: Mon 05 Dec 2011 06:19:46 PM CLST
Category: Bug
Severity: 4 - Important
Priority: 5 - Normal
Item Group: User Interface
Status: None
Privacy: Public
Assigned to: mordante
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: 1.9.12, 1.9.12+svn
Operating System: Debian wheezy
_______________________________________________________
Details:
The automatic Close button added to dialogs with click_dismiss=true when
their (or another widget's) height exceeds the screen's doesn't do anything.
Looking in the source, I couldn't find anything that really handled the
button (whose id as defined in data/gui/default/widget/window_default.cfg is
also "click_dismiss") in the C++ source besides just checking for its
existence and toggling its visibility. A simple line change in the attached
patch makes it work, although I don't know whether the exact retval used in it
is what was intended in the first place (should it be an OK or Cancel
button?).
To reproduce:
- Make sure to use r52177 or later.
- Set the window size to 800x480 (--resolution 800x480 in the command line).
- Connect to the add-ons server for downloading add-ons, and locate "The
Fellowship of the Clay" (try typing "Clay" in the filter box without the
quotes), and click on the Description button once selected.
- There should be a scrollbar to the right of the long description text
(really a scroll_label, but still makes the click_dismiss button appear). Try
clicking on the Close button.
Without the patch, clicking on Close will not close the description dialog,
although pressing Esc on the keyboard will still do the job.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Mon 05 Dec 2011 06:19:46 PM CLST Name: click_dismiss_handling.patch
Size: 461B By: shadowmaster
<http://gna.org/bugs/download.php?file_id=14651>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?19121>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
