Follow-up Comment #2, patch #3194 (project wesnoth):
1. The SSF doesn't yet support ranges of sides (...,2-4,... etc), while
utils::parse_ranges does. So that should be added first; should be a different
patch.
2. I find ignore_something as a name of a variable or parameter confusing
since it's almost a negation. I suggest respect_fog= (def yes).
3. The new tag and the changes to the existing filter_vision tag ar rather
unrelated so should be different patches (can be done easily before commit
though).
4. The new tag shouldn't have a viewing_side= parameter, just a SSF.
5. Perhaps we should deprecate viewing_side= since a wmllint rule for it (and
for the semantics change from "all enemy sides" to "all sides") should be
rather easy to do. The second rule needs to be removed after some time since
it's valid syntax.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3194>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
