URL:
  <http://gna.org/bugs/?23908>

                 Summary: SDL2 SDL_BlitSurface Causes Crashes
                 Project: Battle for Wesnoth
            Submitted by: wedge009
            Submitted on: Mon 28 Sep 2015 08:25:50 AM UTC
                Category: Bug
                Severity: 5 - Blocker
                Priority: 5 - Normal
              Item Group: Graphics
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 1.13.1+dev (sdl2 branch)
        Operating System: Windows + Linux

    _______________________________________________________

Details:

Confirmed on Windows and Linux, probably on OS X as well.

There are at least two cases I've found of SDL_BlitSurface causing crashes or
problems when building with SDL2:

* Resizing the window via mouse-drag on window border. This doesn't always
happen, but do it enough times and it should crash eventually. This instance
of SDL_BlitSurface is called from twindow:draw() (currently line 873 of
window.cpp).

* The other case is when attempting to join a MP game. It doesn't matter if
the default or experimental lobby is used. In some cases, the result is the
display corruption as seen in the attached image. On windows, in many cases, a
crash on SDL_BlitSurface happens instead. This instance is called from
draw_text_line() in font.cpp.

The SDL2 migration guide (https://wiki.libsdl.org/MigrationGuide) talks about
using textures instead of surfaces, but I think this only applies to fixed
graphics resources. There doesn't seem to be any clue provided between the
documentation for SDL_BlitSurface between SDL 1.2 and SDL 2.0 either:

https://www.libsdl.org/release/SDL-1.2.15/docs/html/sdlblitsurface.html
https://wiki.libsdl.org/SDL_BlitSurface

I tried really hard with this one, but I don't think I know enough about
graphics nor Wesnoth code to be of any help on this one beyond testing
possible fixes.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 28 Sep 2015 08:25:50 AM UTC  Name: mp.png  Size: 141kB   By:
wedge009

<http://gna.org/bugs/download.php?file_id=25200>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?23908>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to