On Thu, Apr 26, 2007 at 05:55:52PM +0100, ott wrote: > On Thu, Apr 26, 2007 at 05:36:38PM +0200, Mark de Wever wrote: > > all savegames. I see no need in trying to load stuff of which we know that > > it won't work and might crash Wesnoth. (Smaller breakage or possible > > breakage we can still try to load.) > > It would actually be great if Wesnoth never crashed, even if it was > given complete garbage. It shouldn't be that hard to catch a generic > error "couldn't successfully read the game file" and return gracefully.
I agree that in most cases a proper error message is the best solution, but WML can generate unexpected cases. Most of the time these are caught by and assert (which the user percieves as a crash). The same in the terrain stuff; strings longer than 4 characters aren't allowed and cause an assert. So in this case I know Wesnoth will be terminated due to an assert, that's why I want to avoid the situation and show a dialog before Wesnoth tries to die. Regards, Mark de Wever aka Mordante/SkeletonCrew _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
