On Sat, Jul 11, 2009 at 11:06:32AM +0200, Nils Kneuper wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > [email protected] schrieb: > > Author: oron > > Date: Sat Jul 11 05:27:46 2009 > > New Revision: 36767 > > > > URL: http://svn.gna.org/viewcvs/wesnoth?rev=36767&view=rev > > Log: > > bugfix: adapt to modern FRIBIDI api: > > * The fribidi library (http://fribidi.org) is used to support right to left > > languages (Hebrew, Arabic, Farsi). > > > > * Fribidi >= 0.19 exists for some time and has two incompatible changes: > > - Somewhat different API. > > - Uses pkg-config for configuration instead of fribidi-config which > > isn't shipped anymore. > > > > * Any distribution that tries to compile wesnoth on a system with > > modern fribidi would not have bidi support. An example is > > Fedora which had this situation for about a year: > > https://bugzilla.redhat.com/show_bug.cgi?id=504526 > > The Fedora packages (based on wesnoth-1.6.4) are now fixed. > > > > * I'll wait before fixing it in 1.6.x, 1.4.x until feedback from > > package maintainers of various distributions, as they may carry > > legacy versions of fribidi (e.g: Debian-Lenny). > > Ahhh, several problems with this: > 1) Starting with 1.6.x fribidi is basically deprecated and only used in the > "old" gui elements. No idea if the change is still relevant. Mordante knows > more > about this.
The old widgets still use fribidi and will be around for some time. The rewrite won't be done before the next stable release. > 3) Don't forget to bump the version requirement for fribidi in INSTALL as well > as on the compile page in the wiki. Actually I disagree with this commit, increment of version dependencies should be discussed _before_ making them. Debian doesn't ship fribidi 0.19 so I can no longer use fribidi for Wesnoth. Oron please add conditional code to work with both APIs. Obviously I disagree with backporting this change until it works with both fribidi 0.10 and 0.19. -- Regards, Mark de Wever aka Mordante/SkeletonCrew _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
