On Sat, Jul 11, 2009 at 15:17:16 +0200, Mark de Wever <[email protected]> wrote: > > Actually I disagree with this commit, increment of version dependencies > should be discussed _before_ making them. Debian doesn't ship fribidi > 0.19 so I can no longer use fribidi for Wesnoth. Oron please add > conditional code to work with both APIs. > > Obviously I disagree with backporting this change until it works with > both fribidi 0.10 and 0.19.
When I looked at the fribidi stuff a while back, it looked like it was going to be pretty easy to handle both with a wrapper function that had conditional code generation depending on which version was being used. I really didn't know enough about what it did to do adequate testing so I didn't followup. My memory was that at that time the fribidi stuff was called from only one place. The fribidi function it called had an extra argument in the later versions. And that it looked easy to have the extra argument added in a wrapper function or macro if needed. Possibly it could have been a macro in a new .hpp file. _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
