I think I've implemented all your suggestions in the new patch, and also cleaned it up a bit. I've also removed the autogenerated stuff and added a short howto on the build process.
https://github.com/eugenis/wesnoth-nacl-build/blob/master/wesnoth-1.9.9-nacl.patch The 2000 lines are untrusted code - meaning they are part of the wesnoth binary that users will download. They live in http://code.google.com/p/naclports. Will work with the current chrome. We can't put files on SourceForge without requiring some kind of installation step. The current hosting will work short term (a couple of months). On Wed, Nov 16, 2011 at 7:10 PM, jeremy rosen <[email protected]> wrote: > Ok, so to sum it up > > * the code is unintrusive, and nobody complained about adding it in > 1.10, with some cleanups to do > * the build system maintainer is ok (with some minor cleanups) > > so a non-networked version seems ok for 1.10 once you provide us with > a cleaned up patch... still, I have a couple of questions/problems > > * 2000 lines of changes in what library ? the nacl primitives ? does > it means that it won't be suported until the next version of chrome ? > * Still the problem of server load... for the moment almost all the > users download wesnoth through sourceforge or their distro > infrastructure, but we pay the bandwith on wesnoth.org. Can we host it > on sourceforge ? only host the content somehow on sourceforge ? We > will need to solve this before any public release hit our servers hard > * the network code sounds intrusive, so it's a no-no for 1.10, we will > see if it has to be 1.11 only or if it can be backported once we have > it implemented... > * as for in-place replacement of data files, let's just forget it for > the moment to focus on the 1.10 side... it would be a cool feature to > have but there really is no emergency > > Cheers > > _______________________________________________ > Wesnoth-dev mailing list > [email protected] > https://mail.gna.org/listinfo/wesnoth-dev > _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
