Hi Evgeniy, It looks really interesting.
On Tue, Nov 15, 2011 at 11:45:57PM +0300, Evgeniy Stepanov wrote: > The big list of files is autogenerated. There is a script (part of the > patch) for scanning an installation and building the list. When the list is autogenerated, does it need to be stored in the repository? Isn't it possible to always generate it automatically? Some minor nitpicks on the patch: Regarding the library you're adding, I prefer to have a nacl subdirectory under src instead of in the root directory. This is how we included external libraries in the past as well. Also we name our cpp file .cpp and headers .hpp. Your NaCl headers mention a BSD-style licence and refer to the LICENCE file, there is no such file in the patch. I prefer it to refer to NaCl-LICENCE file. This to avoid any confusion that Wesnoth itself might be shipped under a BSD-style licence. Other then that I'd like to get the code in our repository and before we ship 1.10, I also deem the changes minor. -- Regards, Mark de Wever aka Mordante/SkeletonCrew _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
