The new config files now seems more tidy, but some problems
exists;

- Defintion of gai_strerror() needs to be put after the one in
 <ws2tcpip.h> So either include that in config-compiler.h or
 move the whole ENABLE_IPV6 section to mswindows.h.

- IMHO, important features should be set in Makefile.
 Like -DENABLE_IPV6 and not in .\windows\config.h.

- Some HAVE_* missing for MingW.

- HAVE_GETADDRINFO is no longer used. Drop it?

Proposed patches:

diff -u3 -Hb SVN-Latest\windows\config-compiler.h windows\config-compiler.h
--- SVN-Latest\windows\config-compiler.h     Thu Jul 07 15:00:33 2005
+++ windows\config-compiler.h        Thu Jul 07 15:40:13 2005
@@ -81,9 +81,20 @@
/* MinGW 3.7 (or older) prototypes gai_strerror(), but is missing
   from all import libraries. */
#ifdef ENABLE_IPV6
+# include <winsock2.h>
+# include <ws2tcpip.h>
# undef gai_strerror
# define gai_strerror windows_strerror
#endif
+
+/* Define to 1 if you have the C99 `_Bool' type. */
+#define HAVE__BOOL 1
+
+/* Define to 1 if you have the <inttypes.h> header. */
+#define HAVE_INTTYPES_H 1
+
+/* Define to 1 if you have the `strtoll()' function. */
+#define HAVE_STRTOLL 1
^L
/* -------------------- */
/* MS Visual C section. */
diff -u3 -Hb SVN-Latest\windows\config.h windows\config.h
--- SVN-Latest\windows\config.h      Thu Jul 07 15:00:33 2005
+++ windows\config.h Thu Jul 07 15:46:42 2005
@@ -8,7 +8,7 @@
#define ENABLE_DIGEST 1

/* Define if IPv6 support is enabled. */
-#undef ENABLE_IPV6
+/* #undef ENABLE_IPV6 ; should be in Makefile IMHO */

/* Define if you want the NTLM authorization support compiled in. */
#ifdef HAVE_OPENSSL
@@ -155,7 +155,7 @@
#define SIZEOF_LONG 4

/* The size of a `long long', as computed by sizeof. */
-#define SIZEOF_LONG_LONG 0
+#define SIZEOF_LONG_LONG 8

/* The size of a `off_t', as computed by sizeof. */
#define SIZEOF_OFF_T 4

-------------
--gv

Reply via email to