Gisle Vanem <[EMAIL PROTECTED]> writes:

> Adding yet another define, seems so obfuscate the code more, IMO.

It does, but having #ifdef __COMPILER__ all over the place makes the
code just as obfuscated, only in another way.  And it makes
introducing another compiler that much harder because you have to
review all the scattered __COMPILER__ ifdefs.

> gai_strerror() is used only in host.c, so why not simply add to it's
> top:
>
> #if defined(__MINGW32__) || defined(__WATCOMC__)
> # undef gai_strerror
> # define gai_strerror windows_strerror
> #endif
> Having __COMPILER__ in the source can't be that bad (ref. NeXT and
> __BEOS__).

I'd like to remove such ad hoc checks, not introduce more of them.
The NeXT and BeOS checks could probably have been cleaner too.

Reply via email to