First, a bit of history... From: Steven M. Schweda 15-DEC-2004 14:19:07.55 > [...] > http://www.antinode.org/dec/sw/wget.html > [...]
>From Mauro Tortonesi Sun, 10 Apr 2005 23:21:00 -0500 > [...] > if you want your patches to be merged in our CVS, you should follow > the official patch submission procedure (that is, posting your patches > to the wget-patches AT sunsite DOT dk mailing list. each post should > include a brief comment about what the patch does, and especially why it > does so). this would save a lot of time to me and hrvoje and would > definitely speed up the merging process. > [...] From: Steven M. Schweda Mon, 18 Apr 2005 12:21:44 -0500 (CDT) > [...] > http://antinode.org/ftp/wget/patch1/ > [...] >From Mauro Tortonesi Mon, 19 Sep 2005 17:45:14 +0200 > [...] > the wget code is going through a major refactoring effort. later on, > just before releasing wget 2.0, i promise i will re-evaluate your > patches and merge them if they're not too intrusive. > [...] >From Mauro Tortonesi Tue, 13 Jun 2006 09:38:36 -0700 > [...] > i promise we'll seriously talk about merging your VMS changes into wget > at the beginning of the 1.12 development cycle. > [...] That would be nice, as it would have been nice every other time I've suggested it since Wget 1.9.1 in December 2004. > you'll be very welcome to convince me about the soundness of your code > and the need to merge VMS support into wget [...] Need? None at all, if you have no interest in providing any support for Wget on VMS, and if you have no interest in Wget working well with a VMS FTP server, and if you have no interest in the miscellaneous bug fixes I've made along the way. I simply assumed, as I had done all the necessary work for VMS support (client and server), and fixed a few bugs along the way, that you might find it worth the (pretty small) effort to incorporate my suggested changes. On the topic of the soundness of code, let's consider what happens on a Tru64 system fetching files from a VMS FTP server using the new Wget 1.11-alpha-1, the original Wget 1.10.2, and my Wget 1.10.2b. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - urtx# wg11 -V GNU Wget 1.11-alpha-1 [...] urtx# wg11 -r ftp://alp/wget_test/ --22:15:11-- ftp://alp/wget_test/ => `alp/wget_test/.listing' Resolving alp... 10.0.0.9 Connecting to alp|10.0.0.9|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD [ANONYMOUS.wget_test] ... done. ==> PASV ... done. ==> LIST ... done. [ <=> ] 32 --.-K/s in 0s 22:15:12 (640 B/s) - `alp/wget_test/.listing' saved [32] Removed `alp/wget_test/.listing'. Wrote HTML-ized index to `alp/wget_test/index.html' [198]. urtx# urtx# cat ./alp/wget_test/index.html <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html> <head> <title>Index of /wget_test on alp:21</title> </head> <body> <h1>Index of /wget_test on alp:21</h1> <hr> <pre> </pre> </body> </html> Please observe that no files were downloaded. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - urtx# wg10 -V GNU Wget 1.10.2 [...] urtx# wg10 -r ftp://alp/wget_test/ --22:11:58-- ftp://alp/wget_test/ => `alp/wget_test/.listing' Resolving alp... 10.0.0.9 Connecting to alp|10.0.0.9|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD [ANONYMOUS.wget_test] ... done. ==> PASV ... done. ==> LIST ... done. [ <=> ] 284 --.--K/s 22:11:58 (28.40 KB/s) - `alp/wget_test/.listing' saved [284] Removed `alp/wget_test/.listing'. --22:11:58-- ftp://alp/wget_test/EMPTY/ => `alp/wget_test/EMPTY/.listing' ==> CWD [ANONYMOUS.wget_test.EMPTY] ... done. ==> PASV ... done. ==> LIST ... done. [ <=> ] 32 --.--K/s 22:11:58 (2.91 KB/s) - `alp/wget_test/EMPTY/.listing' saved [32] Removed `alp/wget_test/EMPTY/.listing'. --22:11:58-- ftp://alp/wget_test/EMPTY/ => `alp/wget_test/EMPTY/index.html' ==> CWD not required. ==> PASV ... done. ==> RETR ... No such file `'. --22:11:58-- ftp://alp/wget_test/NON-EMPTY/ => `alp/wget_test/NON-EMPTY/.listing' ==> CWD [ANONYMOUS.wget_test.NON-EMPTY] ... done. ==> PASV ... done. ==> LIST ... done. [ <=> ] 195 --.--K/s 22:11:58 (16.25 KB/s) - `alp/wget_test/NON-EMPTY/.listing' saved [195] Removed `alp/wget_test/NON-EMPTY/.listing'. --22:11:58-- ftp://alp/wget_test/NON-EMPTY/A.TXT => `alp/wget_test/NON-EMPTY/A.TXT' ==> CWD [ANONYMOUS.wget_test.NON-EMPTY] ... done. ==> PASV ... done. ==> RETR A.TXT ... done. Length: 6 (unauthoritative) 100%[====================================>] 6 --.--K/s 22:11:58 (117.19 KB/s) - `alp/wget_test/NON-EMPTY/A.TXT' saved [6] FINISHED --22:11:58-- Downloaded: 6 bytes in 1 files urtx# Please observe the spurious message, "No such file `'.", for the empty directory. As I recall, this spurious message is not related to the FTP server running on a VMS system, and may date back so far as Wget 1.9.1. Please see also: http://www.mail-archive.com/[email protected]/msg08512.html - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - urtx# wget -V GNU Wget 1.10.2b built on osf5.1b. urtx# wget -r ftp://alp/wget_test/ --22:18:33-- ftp://alp/wget_test/ => `alp/wget_test/.listing' Resolving alp... 10.0.0.9 Connecting to alp|10.0.0.9|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD (0) wget_test ... done. ==> CWD (1) wget_test ... done. ==> PASV ... done. ==> LIST ... done. [ <=> ] 284 --.--K/s 22:18:33 (5.42 MB/s) - `alp/wget_test/.listing' saved [284] Removed `alp/wget_test/.listing'. --22:18:33-- ftp://alp/wget_test/EMPTY/ => `alp/wget_test/EMPTY/.listing' ==> CWD (0) wget_test/EMPTY ... done. ==> CWD (1) wget_test/EMPTY ... done. ==> CWD (2) wget_test/EMPTY ... done. ==> PASV ... done. ==> LIST ... done. [ <=> ] 32 --.--K/s 22:18:33 (625.00 KB/s) - `alp/wget_test/EMPTY/.listing' saved [32] Removed `alp/wget_test/EMPTY/.listing'. --22:18:33-- ftp://alp/wget_test/NON-EMPTY/ => `alp/wget_test/NON-EMPTY/.listing' ==> CWD (0) wget_test/NON-EMPTY ... done. ==> CWD (1) wget_test/NON-EMPTY ... done. ==> CWD (2) wget_test/NON-EMPTY ... done. ==> PASV ... done. ==> LIST ... done. [ <=> ] 195 --.--K/s 22:18:33 (3.72 MB/s) - `alp/wget_test/NON-EMPTY/.listing' saved [195] Removed `alp/wget_test/NON-EMPTY/.listing'. --22:18:33-- ftp://alp/wget_test/NON-EMPTY/A.TXT => `alp/wget_test/NON-EMPTY/A.TXT' ==> CWD (0) wget_test/NON-EMPTY ... done. ==> CWD (1) wget_test/NON-EMPTY ... done. ==> CWD (2) wget_test/NON-EMPTY ... done. ==> PASV ... done. ==> RETR A.TXT ... done. Length: 6 (unauthoritative) 100%[====================================>] 6 --.--K/s 22:18:33 (117.19 KB/s) - `alp/wget_test/NON-EMPTY/A.TXT' saved [6] FINISHED --22:18:33-- Downloaded: 6 bytes in 1 files urtx# Please observe the correct behavior. (It works when run on a VMS system, too.) For one of many examples of a case where the current official VMS FTP server code fails, please see: http://www.mail-archive.com/[email protected]/msg01454.html http://www.mail-archive.com/[email protected]/msg04588.html http://www.mail-archive.com/[email protected]/msg06490.html - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - "[...] convince me about the soundness of your code [...]" Oh, I get it. This was a joke, right? And I took it seriously. I'm such a dope sometimes. But seriously... Have you ever _looked_ at any of my suggested changes? > however, for the moment i have to focus on the 1.11 release. That's your choice to make, but every such postponement increases the amount of work for me, and makes it that much harder to create a set of suggested changes which are closely correlated with the current code. But, hey. It's not my program, and you're free to develop it (or not) as you wish. ------------------------------------------------------------------------ Steven M. Schweda [EMAIL PROTECTED] 382 South Warwick Street (+1) 651-699-9818 Saint Paul MN 55105-2547
