"Christopher G. Lewis" <[EMAIL PROTECTED]> writes:

> c:\cvsprojects\wget\trunk\src\sysdep.h(215) : warning C4142: benign
> redefinition of type
> http.c(540) : warning C4090: 'function' : different 'const' qualifiers
> http.c(558) : warning C4090: 'function' : different 'const' qualifiers
> http.c(736) : warning C4090: 'function' : different 'const' qualifiers

I don't understand this warning.  Do you?

> c:\cvsprojects\wget\trunk\src\sysdep.h(215) : warning C4142: benign
> redefinition of type

This one (repeated several times) is the result of HAVE_UINTPTR_T
being incorrectly defined on your system.  That should be fixed in
windows/config-compiler.h.

> utils.c(1917) : error C2036: 'const void *' : unknown size
> utils.c(1917) : error C2036: 'const void *' : unknown size

In 1.11-alpha1, the line 1917 contains an assignment from char * to
another char *; there is no const void * anywhere.

> c:\cvsprojects\wget\trunk\src\openssl.c(152) : warning C4715:
> 'key_type_to_ssl_type' : not all control paths return a va
> lue

The compiler is apparently not aware that abort() aborts.

> Looks like the big error is here: 
> utils.c(1902) 
> base64_encode (const void *data, int length, char *dest)

Which version of Wget are you compiling, exactly?  1.11-alpha1 does
not contain such code on line 1902 of utils.c.

The latest subversion code does, though, so I guess you are compiling
that.  The bug is a GCC-ism that crept in unwanted, and this patch
(now applied) should fix the it:


2006-06-21  Hrvoje Niksic  <[EMAIL PROTECTED]>

        * utils.c (base64_encode): Cast void pointer to char * before
        doing arithmetic.

Index: src/utils.c
===================================================================
--- src/utils.c (revision 2156)
+++ src/utils.c (working copy)
@@ -1914,7 +1914,7 @@
   };
   const unsigned char *s = data;
   /* Theoretical ANSI violation when length < 3. */
-  const unsigned char *end = data + length - 2;
+  const unsigned char *end = (const unsigned char *) data + length - 2;
   char *p = dest;
 
   /* Transform the 3x8 bits to 4x6 bits, as required by base64.  */

Reply via email to