[ http://issues.apache.org/jira/browse/WICKET-151?page=comments#action_12457018 ] Eelco Hillenius commented on WICKET-151: ----------------------------------------
I've thought about that before - long time ago - as that is something we don't do now either. I don't think we should do this, as code anywhere, anytime could deliberately set the session. If people want to support users changing their locale in the middle of a session by changing their browser settings, imo, that should be done with a custom request cycle. For convenience we could provide such a request cycle, or we could even go so far as to build it in in the standard request cycle and let it depend on a application setting. > set session locale when constructing session object > --------------------------------------------------- > > Key: WICKET-151 > URL: http://issues.apache.org/jira/browse/WICKET-151 > Project: Wicket > Issue Type: Improvement > Affects Versions: 2.0, 1.3 > Reporter: Eelco Hillenius > Assigned To: Eelco Hillenius > Fix For: 2.0, 1.3 > > > Currently, we create the session objects like this: > WebApplication#getSession: > if (session == null) > { > // Create session using session factory > session = getSessionFactory().newSession(request); > // Set the client Locale for this session > session.setLocale(request.getLocale()); > What I propose is to change the constructor from Session/ WebSession to take > in a Locale parameter as well. That would make it possible for custom session > classes to fix the locale by setting it in the constructor. Now that is only > possible by overriding Session#getLocale -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
