Well, technically, the threadlocal approach has the "least problems". But I don't think that makes it the best at all. The "problem" it "fixes" is /highly/ unlikely to matter to anyone... ever. And the expense of the fix is conceptual muddiness, greater code complexity and increased memory consumption. I still think session is quite a bit better than page / threadlocal. The biggest thing is that it makes really good sense. It's very easy to explain the concept and our code may actually shrink a little. I think that's the right direction.
Martijn Dashorst wrote: > > Both have their pro's and con's. I'd suggest that we just choose the > one with the least problems, make sure we keep current functionality > working. Any fancy stuff can go into the next release. If we want to > 'upgrade' our validation messages. > > On 4/1/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: >> Can I please get some opinions on >> https://issues.apache.org/jira/browse/WICKET-442 ? >> >> The session option is attractive to me, though I'd like to be sure >> component specific messages get cleaned up in a fashion that will >> still work with redirects to pages etc. In case of the session option, >> I'd like to get rid of the getFeedbackMessages methods of Page >> altogether. >> >> Eelco >> > > > -- > Learn Wicket at ApacheCon Europe: http://apachecon.com > Join the wicket community at irc.freenode.net: ##wicket > Wicket 1.2.5 will keep your server alive. Download Wicket now! > http://wicketframework.org > > -- View this message in context: http://www.nabble.com/proposal-for-feedback-messages-refactor-tf3502131.html#a9783045 Sent from the Wicket - Dev mailing list archive at Nabble.com.
