So I committed two patches based that are using the session for storing the feedback messages. Basically the choice is whether we support the option - however theoretic it is - to be able to set messages on a page to be rendered sometime later or clean up all messages related to any page. The advantage of the latter is that we'll never have any memory leaks, though it limits the functionality compared to what we have now.
So... can you please tell me what your favorite choice/ patch is? Eelco On 4/1/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
I think I have a working patch. I'll try to commit it tonight. Eelco On 4/1/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > agreed on all points. > > > Eelco Hillenius wrote: > > > >> increased memory consumption. > > > > For clarity, it doesn't consume more. Just the same, whereas the > > session would consume less compared to what we have now. > > > >> I still think session is quite a bit better than page / threadlocal. > > > > I think so too, but we have to find a good way to clean it up. > > Feedback messages are probably the most refactored piece in Wicket, so > > we have to be careful not to fall into traps we've fallen into before. > > > > Eelco > > > > > > -- > View this message in context: http://www.nabble.com/proposal-for-feedback-messages-refactor-tf3502131.html#a9783329 > Sent from the Wicket - Dev mailing list archive at Nabble.com. > >
