[x] Yes, ask the IPMC to ratify the 1.3.0-incubating-beta1 release
[ ] No, don't ask the IPMC
Stuff checked:
- *.jar/MANIFEST.MF - looks good (more complete with information)
- DISCLAIMER/NOTICE/LICENSE in META-INF in jar files (also sources.jarand
javadoc.jar)
- DISCLAIMER at all
- mvn install in dist works out of the box :)
(I haven't run rat on the release, sry!)
Things found:
- Minor things:
- root/DISCLAIMER in the distribution says "Wicket Extensions is
an...". Should be something like "Apache Wicket is an..."
- *incubating-beta1-tests.jar in our repositories? Is it on
purpose that we deploy a jar with our tests in it? Seems a
little weird to
me.
- DISCLAIMER/NOTICE/LICENSE in examples.war is in
WEB-INF/classes/META-INF and not in META-INF. Is this a showstopper?
- Tiny (microscopic) things:
- root/NOTICE says "src/jdk-1.4/wicket-extensions" and "src/jdk-
1.4/wicket-spring", but "src/jdk-1.4/wicket-quickstart/NOTICE"
(remove or add NOTICE, to all path)
In general I haven't found anything that would warrant me to vote against
the release. But I think we should consider if "beta1" is the appropiate
version because the api might not be stable enough[1]. This release is not
only for the IPMC so we have to consider our users. My personal opinion is
that it doesn't matter much (but [1] is a big change), so go ahead and
release. WDYT?
Frank
[1]:
http://www.nabble.com/Last-BIG-refactor%3A-onAttach-onBeforeRender-behavior-change-in-1.3-tf3577350.html#a10162455
