Martijn Dashorst wrote: > The vote: > [+] Yes, ask the IPMC to ratify the 1.3.0-incubating-beta1 release > [ ] No, don't ask the IPMC
I skimmed through libs, copyrights, etc and have minor remarks. These don't prevent the release to happen, but are merely for info and future action if you consider them valuable. - it would be nice to have NOTICE, README, etc have a ".txt" extension for those people that use a graphical file browser. - the NOTICE file is in my opinion overzealous. You don't need to quote there each and every bit of software that is used by Wicket, unless it does require attribution in a way similar to Apache's notice file. - this big NOTICE file shows however that Wicket has reused-by-copying parts of a number of other libraries. While totally ok from a legal point of view, that means the project has to take care or possible updates, bugfixes, etc (not talking as well of the lack of cross-pollination of communities implies). I understand this is to reduce the number of external dependencies of Wicket, but most of these libraries are pretty common such as Doug Lea's concurrent, jakarta-commons-*. For what it's worth, and nothing blocker. So let's get Wicket out of the incubator! Sylvain -- Sylvain Wallez - http://bluxte.net
