I actually like both of your approaches (who wonders chief of table with
chief of DataView :). Like Igor says it is definately better to have
components which have it all in one piece nicely together. On the other
hand Phil's ColumnDataProvider has it's elegancy. It does not span an
extra hierarchy and is IMO more flexible. I was actually thinking of a
TableModelDataProvider which has an abstract method IModel getModel(int
row,int col) - useful for calculated things or tables with a lot of empty
elements.
Of my head: Why not combine both approaches? Have a generified DataTable
(TableView) which uses for the rows an DataView and mainly has a method
populateDataItem(DataItem di, int col, int row). Than make special panels
which use this generic TableView and automatically wrap the IDataProviders
in sepcialized providers or demand differnt models or whatsoever.
Christian
PS: The only reason for the offset I can think of is that you might want
to start with an element which by the current calculation lies in the
middle of a row.
On Tue, 16 Aug 2005 12:12:16 -0700, Igor Vaynberg <[EMAIL PROTECTED]>
wrote:
I told you I didn't like it :) The whole process should be smoother, why
cant the internal view simply get the iterator from the external view and
use that. Why have a whole other wrapper/provider to implement.
What is this offset? When using pageddataview you should use the page
number
to offset, when using a normal dataview you should use setfirstindex().
-Igor
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Phil Kulak
Sent: Tuesday, August 16, 2005 11:32 AM
To: wicket-user@lists.sourceforge.net
Subject: Re: [Wicket-user] Re: ColumnedDataProvider
startIndex problems
Are we even sure we want this functionality in the
dataprovider? I wrote that class to get people's reactions to
the concept, but I don't think I got any feedback. I'm not
sure that's where the functionality belongs, but you can't
just subclass the whole heirarchy either.
On 8/16/05, Gili <[EMAIL PROTECTED]> wrote:
>
> On second thought... Instead of me adding this
functionality
> into ColumnedDataProvider can we add a IDataProvider wrapper that
> provides this functionality? So I'd have the original
IDataProvider,
> wrapped by the offset-producing-IDataProvider, then the
ColumnedDataProvider.
>
> Or is this going to be completely unnecessary in
the new design?
>
> Gili
>
> Gili wrote:
> >
> > There is no way to offset the ColumnedDataProvider
beginning index.
> > This functionality doesn't really belong here but until
the refactor
> > of contrib-data I don't think there is a cleaner way.
> >
> > So I'll be adding ColumnedDataProvider.setStartIndex() ok?
> >
> > Gili
>
> --
> http://www.desktopbeautifier.com/
>
>
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices Agile & Plan-Driven Development * Managing
Projects & Teams
> * Testing & QA Security * Process Improvement & Measurement *
> http://www.sqe.com/bsce5sf
> _______________________________________________
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference &
EXPO September 19-22, 2005 * San Francisco, CA * Development
Lifecycle Practices Agile & Plan-Driven Development *
Managing Projects & Teams * Testing & QA Security * Process
Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle
Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing &
QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
--
Christian Essl
___________________________________________________________
Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user