https://bugzilla.wikimedia.org/show_bug.cgi?id=16294
--- Comment #2 from Brion Vibber <[EMAIL PROTECTED]> 2008-12-08 22:53:13 UTC
---
This'll need some parser test cases that cover:
a) the previously broken cases, to confirm they don't regress in future
b) any new functionality, to confirm it works as expected and doesn't regress
in future
A couple quick notes...
+ preg_match("#{$this->mPre}<span
id=\"(cite_ref-(\w*)::(\d*)::.*)\"><a href=\"(.*)\".*>(.*)</a>$#U",
$strings[$i], $match);
^ I have to admit I'm pretty leery about this kind of regex on HTML code. These
can be fragile, and a minor change in markup could result in breakage, even
assuming the regexes have no flaws with the original markup.
Adding regression tests helps. ;)
+ 'cite_references_footnote_labels' => '* † ⁑ ‡ § ‖ ¶',
^ Is this really an appropriate progression for footnote labels? § and ¶
refer to section and paragraph numbers, normally; do they get reused for
footnotes in this fashion?
+ 'cite_reference_bra' => '[',
+ 'cite_reference_ket' => ']',
^ This naming scheme is cute, but a bit unclear. :) I'd recommend using clear,
legible names such as "open_bracket" and "close_bracket", or more simply a
single message with the value '[$1]'.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
