https://bugzilla.wikimedia.org/show_bug.cgi?id=16294
Brad Jorsch <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[EMAIL PROTECTED]
--- Comment #6 from Brad Jorsch <[EMAIL PROTECTED]> 2008-12-11 16:11:27 UTC ---
How odd. Although the headers in the patch claim it to be against r43263, I had
to go back to r38094 to get it to apply cleanly. Anyway, I have a few
criticisms (all testing done on a local MW installation at r44443, except the
Cite extension at r38094 + patch):
Since the patch is against r38094 any changes since then are lost, until
someone goes to the trouble of merging by hand. In particular, I notice:
* A fix so {{#tag:ref||name=foo}} won't blow up.
* Code to detect unclosed refs.
* $wgAllowCiteGroups.
* Use of Sanitizer::escapeId instead of validateName.
Something like "$wgMergeCitations" would probably be preferable to "Comment out
this line to disable merging".
If I enter something like '<span class="ref_DB">1</span>' into the wikitext, it
gets magically changed into a reference (or "[]"!). And if I enter '<span
class="ref_DB"></span>', I get an internal error. You should probably (somehow)
pick an identifier that cannot occur in wikitext.
Customized MediaWiki:Cite_references_link_one and friends need to be updated if
the "footnote" group is used, as they are unlikely to contain the needed $4
otherwise. This should be noted somewhere prominent.
Output like "[†–‡]" makes little sense to me, as there is not really a
natural ordering to the symbols as there is with numbers. OTOH, if someone
customized MediaWiki:cite_references_footnote_labels to use "a b c" instead of
"* † ⁑" then it would make sense to merge there.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
