https://bugzilla.wikimedia.org/show_bug.cgi?id=16294
Nicholas Wilson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5572 is|0 |1 obsolete| | --- Comment #7 from Nicholas Wilson <[email protected]> 2008-12-13 11:34:04 UTC --- Created an attachment (id=5577) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5577) patch against r44396 Thanks for the useful feedback. It seems I was indeed working from a version of cite quite a bit older than my svn MW. I have manually merged the recent improvements into my code. In particular, great minds must think alike, as I was surprised to find that after switching to Sanitizer::escapeId from my validateName, I still passed the parser tests, because my carefully chose regexps were identical to the ones in the Sanitizer class! (Also, I had removed $wgAllowCiteGroups per the comment to 'remove when groups are fully tested', and given that they are now on by default and used on the main WP.) The way the new tags are written however makes it a little problematic to just turn off merging. If a $wgMergeCitations feature is wanted, then it can be done easily, but it would be only for aesthetic reasons, not reliability, as nearly the same amount of new code would still be run in each case. I have cunningly fixed the problem of entering identifiers which can occur in wikitext by re-using the <ref> tag itself, which is neat, because it is the only one we can count on being parsed the way the want. It also happens to work well with the 'unclosed ref' code to make sure that any dangerous <ref> or </ref> still in the wikitext is not a full tag which would mess things up. It looks a spot fragile, but theoretically should work, and I have tested both the cases of too many <ref>s and too many </ref>s, neither of which cause problems. Thanks for the reminder to update all the documentation, which I can definitely remember to do if/when this goes through. I have shortened and improved the dashing function now, and it adds footnotes as a special case. Thanks for pointing this out. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
