https://bugzilla.wikimedia.org/show_bug.cgi?id=19416
--- Comment #10 from Splarka <[email protected]> 2009-07-02 03:14:59 UTC --- (In reply to comment #8) > Created an attachment (id=6289) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6289) [details] > Make Geshi borders mimic <pre> borders in all skins > > There's my implementation. I don't see the validity of much of your argument. And I don't see the validity of yours. What geshi returns isn't a pre, why should it look like one other than for historical nostalgia? > Yes there are fourteen additional characters in each skinfile that are > redundant if Geshi is not installed on the wiki, but the overall bytecount is > still lower... This isn't about bytecount, this is about maintainability. Copying the styles given to <pre> for all skins for all wikis for all eras would be /very/ annoying. 1. Skin-specific classes are rather recent, but borderless GeSHi has been around for several years, other wikis may wish to update the extension without updating their mediawiki version. So skin-specific hacks would have to go into each MediaWiki:Skinname.xxx for them. 2. Styles change, if the trunk GeSHi extension (which was attempting to mimic all existing pre) was used on an older mediawiki, it may become unmatched. Likewise an older verison of the extension on a newer version of MediaWiki (say, with a new skin) would not match. 3. There isn't any good place to put it, except inline (per GeSHi's lack of any non-inline CSS other than the MediaWiki:Geshi.css). As one line it would be less spammy to the page source (so in this case, it is about byte count). Per one of my suggestions, this /was/ done at en.wp -> http://en.wikipedia.org/w/index.php?title=MediaWiki:Geshi.css&diff=299560828&oldid=194192714 ... but this, as a single project, is maintainable. Again, if you want this, open a separate bug with a separate goal (as you said, they aren't mutually exclusive). My goal is to get the extension, with newer versions of the backend, to give it any kind of visual border at all. > we can't also add your line to shared.css Um, GeSHi is an extesion, lets please not go modifying core skin/style files for this. Your patch is completely inappropriate. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
