https://bugzilla.wikimedia.org/show_bug.cgi?id=19416





--- Comment #11 from Happy-melon <[email protected]>  2009-07-02 14:34:57 
UTC ---
(In reply to comment #10)
> And I don't see the validity of yours. What geshi returns isn't a pre, why
> should it look like one other than for historical nostalgia?

This is the core of the problem, IMO.  <pre> is used primarily to show code
snippets.  Geshi is used *entirely* to show code snippets.  Semantically, it
makes a lot of sense for Geshi's output to be wrapped in a pre.  Comment#9
seems to be explaining why this behaviour was changed; can you elaborate,
Niklas?

> > we can't also add your line to shared.css
> 
> Um, GeSHi is an extesion, lets please not go modifying core skin/style files
> for this. Your patch is completely inappropriate.
> 

There are lines in shared.css from the Cite extension; together with a comment
noting that it's horrible and shouldn't be done that way, but it's there
nonetheless.  

In general I'm concluding that I do not understand why Geshi no longer wraps
its output in <pre> tags.  Can someone give me a usecase (except for the
'inline' mode, naturally) when having Geshi output formatted in this way (and
hence looking like generic <pre> tags) is not a Good Thing?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to