https://bugzilla.wikimedia.org/show_bug.cgi?id=42513
Tyler Romeo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch-in-gerrit Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] --- Comment #7 from Tyler Romeo <[email protected]> --- (In reply to comment #6) > (In reply to comment #3) > > I googled a little for a reasonable JS URI parsing library that could > > replace > > those half-baked regexes, and found this: https://gist.github.com/2428561 > > > > It seems genius and is 100% correct. Is it a good idea to use something like > > this? If it is, I can implement it. > > That's not a URI parsing library, that's an unreliable hack using <a href=""> > parsing. See the comments there. > > On further investigation and following links from that gist, it looks like > the > regexes in mw.Uri aren't so half-baked. > > They actually come from here: > http://blog.stevenlevithan.com/archives/parseuri Indeed. You'll also notice that the user and password aren't parsed at all in that implementation. Also, https://gerrit.wikimedia.org/r/44665 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
