https://bugzilla.wikimedia.org/show_bug.cgi?id=42513
--- Comment #8 from Bartosz Dziewoński <[email protected]> --- (In reply to comment #6) > On further investigation and following links from that gist, it looks like > the > regexes in mw.Uri aren't so half-baked. > > They actually come from here: > http://blog.stevenlevithan.com/archives/parseuri If they weren't half-baked, mw.Uri wouldn't crash on '@' in the URL. These regexes are already awful (177 characters? Seriously?), and are bound to get worse as we discover more edge-cases. What about password with a '@' in it? (Yeah, this is allowed as far as I know, and works.) What about whitespace in the authority part? (This isn't allowed, but those regexes match it just fine.) While on second though the <a>-abuse I linked isn't a good idea, we really need a serious parsing library. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
