https://bugzilla.wikimedia.org/show_bug.cgi?id=42513
--- Comment #11 from Bartosz Dziewoński <[email protected]> --- (In reply to comment #10) > I wouldn't attempt to make a comprehensive URI parsing library in JavaScript. > The first reason is because it's unnecessary. With the fix I just uploaded to > Gerrit, there should not be any more bugs in this function. I just pointed out a glaring one above. (In reply to comment #8) > What about whitespace in the authority part? (This isn't allowed, > but those regexes match it just fine.) I'm sure there are more, waiting to be uncovered. > Secondly, the > regular expression would be absurdly complicated. URIs have specific sets of > characters that can be included only in certain sections. I wrote a regex for > an official URI once when I was working on the PHP version of this class > (still > in Gerrit), and it was so confusing it took days to get it working properly. Of course, I know this. That's why I'm suggesting using the work of someone who has already spent time pulling his hair out to get this right; or at least just taking those crazy regexes in from some other library. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
