https://bugzilla.wikimedia.org/show_bug.cgi?id=49087

--- Comment #2 from MZMcBride <[email protected]> ---
Yeah, I was just poking at this.

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Thanks.git;a=blob;f=ApiThank.php;h=23f72b77df74cd5f4369ed1b4ec03e31902b052c;hb=HEAD#l65

---
// Log it if we're supposed to log it
if ( $wgThanksLogging ) {
    $logEntry = new ManualLogEntry( 'thanks', 'thank' );
    $logEntry->setPerformer( $agent );
    $target = User::newFromId( $recipient )->getUserPage();
    $logEntry->setTarget( $target );
    $logid = $logEntry->insert();
}
---

That appears to be the relevant code to update the logging table.

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Thanks.git;a=blob;f=ThanksLogFormatter.php;h=b55c2b2da0cb77c8a3acc01adc7dba111f536ab6;hb=HEAD

---
<?php
/**
 * This class formats log entries for thanks
 */
class ThanksLogFormatter extends LogFormatter {
    protected function getMessageParameters() {
        $params = parent::getMessageParameters();
        // Convert target from a pageLink to a userLink since the target is
        // actually a user, not a page.
        $recipient = User::newFromName( $this->entry->getTarget()->getText(),
false );
        $params[2] = Message::rawParam( $this->makeUserLink( $recipient ) );
        return $params;
    }

    public function getPreloadTitles() {
        // Add the recipient's user talk page to LinkBatch
        return array( Title::makeTitle( NS_USER_TALK,
$this->entry->getTarget()->getText() ) );
    }
}
---

This is the code that outputs the log entries at [[Special:Log/thanks]].

So... this would be a trivial change, iff the data were being logged.

(In reply to comment #1)
> The Log entry was designed specifically to not include the edit. That allows
> the substance of the thanks to remain private while still providing a public
> record of the action in the event of someone using it for spamming.

Yeah... I didn't even realize thanks were publicly logged until today. I tend
to agree that some discretion might be appropriate here. This bug may
ultimately be a wontfix, but it'll be helpful to have a record of the design
decision.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to