Web browser: ---
            Bug ID: 59892
           Summary: Updating commit message in Gerrit resulted in new
                    patchset with older patchset code
           Product: Wikimedia
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Git/Gerrit
    Classification: Unclassified
   Mobile Platform: ---

What happened:
During code review of
I noticed an error (line 208 of patchset 19 should concatenate, not assign).
After pointing this out to MaxSem, he fixed the problem with patchset 20
Then, I made some minor changes to the commit message of patchset 20 in the
Gerrit interface:

However, after making the changes to the commit message, the change that MaxSem
made in patchset 20 disappeared from patchset 21:

It didn't occur to me retest patchset 21 since I had just updated the commit
message, so I merged patchset 21 and wound up breaking mobile diffs in
production :(

Expected behavior:
Gerrit would have kept everything from patchset 20 with the exception of the
new commit message.

You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
Wikibugs-l mailing list

Reply via email to