https://bugzilla.wikimedia.org/show_bug.cgi?id=59892
Daniel Kinzler <daniel.kinz...@wikimedia.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |daniel.kinz...@wikimedia.de
--- Comment #2 from Daniel Kinzler <daniel.kinz...@wikimedia.de> ---
(In reply to comment #1)
> What you're seeing could be explained by the following time line:
>
> * patch set 19 gets uploaded
> * Person A opens the change's page
> * Person B uploads patch set 20
> * Person A clicks “Edit Commit Message” (still being on patch set 19,
> as patch set 20 did not yet show up)
> * Person A clicks “Submit” in the “Create New Patch Set” dialog.
I think this analysis is correct. I have seen this issue before.
> To me, gerrit's behaviour does not feel wrong.
It's a failure to detect an edit conflict, resulting in silent data loss.
That's horribly wrong.
> Your expected behaviour would make others complain that they clicked
> “Edit Commit Message” for patch set 19, and not patch set 20 and that
> gerrit should not second guess them by automatically switching to
> patch set 20 behing the users back.
It should do what mediawiki and git both do silently to resolve edit conflicts:
it should just splice your change into the new revision if there are no
conflicts.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
