egardner added a comment.

  I agree with @Mholloway; I think this is a case of diverging assumptions 
being made by the Wikidata and Mediainfo teams.
  
  The source of the error in question is an AJAX request that is fired in the 
`wikibase.entityPage.entityLoaded` hook (defined in 
`Wikibase/repo/resources/wikibase.entityPage.entityLoaded.js`).
  
  The AJAX request causes 
`Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision` to be 
called. That method logs a warning if there is no `entityRevision` for a given 
entity ID, i.e. if there is no structured data available for it. It looks like 
the assumption within Wikibase is: if you have gotten to this point and no 
relevant data actually exists, something is very wrong.
  
  From the perspective of the MediaInfo extension, all that has happened is 
that we've checked to see if any structured data already existed for a given 
file, found none, and went on to set up an empty set of UI elements (caption & 
statement panels). Every visit to a file page will cause that AJAX request to 
be launched, whether or not there is any data to retrieve.
  
  I'm not sure if the best solution is to change that AJAX request (or the PHP 
method it eventually triggers) to treat null results as non-errors, or if some 
other approach should be used to determine whether or not structured data 
exists for a given file. It would be good to have a discussion with members of 
both teams. But in the mean time, I don't think this is a real "error", even 
though it will clutter the logs until we can come up with a solution.

TASK DETAIL
  https://phabricator.wikimedia.org/T229482

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: egardner
Cc: egardner, Mholloway, Lydia_Pintscher, Ladsgroup, alaa_wmde, Liuxinyu970226, 
Aklapper, brennen, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, 
Ricordisamoa, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair, Keegan
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to