daniel added a comment.
Looking at the code in the patch, it seems like the error is triggered when a) an ID is known and b) the revision is found but c) no entity could be loaded. Back then, this would have indicated a serious problem, like corrupt serialization or some such. With MediaInfo, this can now happen legitimately, with no corruption: a) the MediaInfoId is derived from the internal page ID, so it may be known to the system even if no MediaInfo exists on the page. And b) the revision row can be loaded, even if there is no MediaInfo slot on the page. So as far as I can see, failing to load an entity for a known EntityId that refers to an existing page is no longer an exceptional condition worth logging. My understanding however is incomplete. If the caller is expected to know whether the entity exists, and asking for a non-existing entity to be loaded is considered an error, then it should still be logged. Or better, an exception should be thrown. TASK DETAIL https://phabricator.wikimedia.org/T229482 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, WMDE-leszek, Smalyshev, egardner, Mholloway, Lydia_Pintscher, Ladsgroup, alaa_wmde, Liuxinyu970226, Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Jonas, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g, Krenair, Keegan
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
