Joe added a comment.
In T240884#5789392 <https://phabricator.wikimedia.org/T240884#5789392>, @Ladsgroup wrote: >> Though this is mainly an implementation detail and not significant in terms requirements or pros/cons. > > I disagree for a couple of reasons: gRPC is faster. According to some measurements in ASP.net <https://medium.com/@EmperorRXF/evaluating-performance-of-rest-vs-grpc-1b8bdf0b22da> (not in php) it's seven times faster than HTTP/JSON. That would be an important factor in deciding whether we should go with standalone service or another direction. > The other reason I think it's important that is this would be the first time we are going to use gRPC in production, meaning introducing new dependencies (in php) and services, this is cross cutting and would involve more work from services and SRE than HTTP+JSON solution. Also, another reason also is that the API spec of the regex implementation is hard to undo as it'll be used in several places not just one part of Wikibase. I think you're both right - gRPC is an implementation detail in answering the first question: - Does a standalone service make sense? but if the answer is yes, then it's something we should discuss in the RFC process for the reasons @Ladsgroup outlined. TASK DETAIL https://phabricator.wikimedia.org/T240884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Joe Cc: Joe, WMDE-leszek, Volans, sbassett, Krinkle, Agabi10, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Scott_WUaS, Izno, SBisson, Perhelion, Wikidata-bugs, Base, aude, GWicke, Bawolff, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
