daniel added a comment.

  In T251457#6099971 <https://phabricator.wikimedia.org/T251457#6099971>, @Tgr 
wrote:
  
  > MediaWiki automatically wraps the entire request in a transaction if it 
encounters a write which does not do its own transaction handling. So something 
unrelated to saving could have started the transaction, like AbuseFilter taking 
an action, or a session refresh (although I would expect either to show up in 
Logstash).
  
  That's true, but an automatic transaction would have been flushed before 
starting the explicit transaction for the revision creation, I think...
  
  My plan of action for now:
  
  - make database::lock() flush automatic transactions.
  - make database::lock() flush warn about explicit transactions (and fail 
tests)
  - make the Parser warn if an explicit transaction is in progress (and fail 
tests)
  
  I hope that this will trigger the condition that causes this timeout in 
production, by making tests fail.

TASK DETAIL
  https://phabricator.wikimedia.org/T251457

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: Tgr, Agusbou2015, Pchelolo, daniel, DannyS712, Jdforrester-WMF, Krinkle, 
Marostegui, Liuxinyu970226, brennen, Bugreporter, LarsWirzenius, Hogue, 
Aklapper, Naike, eprodromou, darthmon_wmde, Nandana, Banyek, Rayssa-, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, 
Rxy, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to