Lucas_Werkmeister_WMDE added a comment.
Upon closer inspection: - Both test methods skip themselves if Repo is not enabled. - The class under test, `SqlChangeStore`, hard-codes the `wb_changes` name, which only exists on Repo wikis. - `SqlChangeStore` is also not used at all from Client or DataAccess – the only such class in the `Wikibase\Lib\Store\Sql` namespace, if I’m not mistaken. (I didn’t check the `Terms` subnamespace, only classes directly in `Wikibase\Lib\Store\Sql`. As far as I can tell, all of them are used in Client and/or DataAccess, but `SqlChangeStore` is only used in Repo, and in one other Lib test.) I’m tempted to say that `SqlChangeStore` and its test should completely move to the Repo. However, in that case I’m not sure what to do with `EntityChangeLookupTest`, because the test uses `SqlChangeStore` to write changes to the `wb_changes` table (so that `EntityChangeLookup` can then read them back). Would it make sense to move `EntityChangeLookupTest` to Repo even though the class it tests stays in Lib? TASK DETAIL https://phabricator.wikimedia.org/T259814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Tarrow, Ladsgroup, ItamarWMDE, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
