Ladsgroup added a comment.
In T259814#6366373 <https://phabricator.wikimedia.org/T259814#6366373>, @Lucas_Werkmeister_WMDE wrote: > I’m tempted to say that `SqlChangeStore` and its test should completely move to the Repo. I think I suggested this too a while back but I don't know why we decided against that, probably the EntityChangeLookupTest? I would be happy with copying the logic of production to test to decouple them and I hope this production code is tested in another place (like EntityChangeTest?) I feel it's more of "mocking" the logic than leaving it untested. TASK DETAIL https://phabricator.wikimedia.org/T259814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Tarrow, Ladsgroup, ItamarWMDE, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
