awight added a comment.

  This line can be removed,
  
  >   event_user_id != 0
  
  Anonymous users are already filtered out with `event_user_is_anonymous = 
FALSE`, and anyway `event_user_id` is set to `null` rather than `0` for 
anonymous (or revision-deleted) users.
  
  I think the bot tests can be simplified to, `NOT 
ARRAY_CONTAINS(event_user_groups, \'bot\')`, why would we need to check the 
historical column?  If the user was classified as a bot at a time but now is 
not, shouldn't we respect the updated classification?  And the specific tests 
against the event_user_is_bot_by columns seem to be redundant.
  
  The text says your filter will include the Item namespace (0), but the query 
only includes the talk pages: `page_namespace = 1`.  Maybe this explains why 
there's such a low user count?  I would have expected to see virtually all 
non-bot users who have edited wikidata.
  
  Can you share more about the query that produced `reactivations.csv`?  I 
can't tell from the information provided what counts as a "period of 
inactivity".

TASK DETAIL
  https://phabricator.wikimedia.org/T282563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: GoranSMilovanovic, awight
Cc: awight, WMDE-leszek, Manuel, Lydia_Pintscher, Aklapper, Jan_Dittrich, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to