Lucas_Werkmeister_WMDE added a comment.

  It is used, just not through the `WikibaseRepo` getter:
  
  name=extension-repo.json
                "wbparsevalue": {
                        "class": "\\Wikibase\\Repo\\Api\\ParseValue",
                        "factory": "\\Wikibase\\Repo\\Api\\ParseValue::factory",
                        "services": [
                                "StatsdDataFactory",
                                "WikibaseRepo.ApiHelperFactory",
                                "WikibaseRepo.DataTypeFactory",
                                "WikibaseRepo.DataTypeValidatorFactory",
                                "WikibaseRepo.ExceptionLocalizer",
                                "WikibaseRepo.PropertyDataTypeLookup",
                                "WikibaseRepo.ValidatorErrorLocalizer",
                                "WikibaseRepo.ValueParserFactory"
                        ]
                },
  
  But I think the value parser is the wrong point to do this normalization 
anyways. We want to normalize on save, not on parse – even if someone directly 
creates the JSON for a commonsMedia value and submits it to the API without 
using `wbparsevalue`, and that JSON specifies the file name with an underscore, 
we still want to save it using a space, just as we do (I assume) for sitelinks.

TASK DETAIL
  https://phabricator.wikimedia.org/T251480

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Manuel, Lydia_Pintscher, Addshore, 
Raymond, Multichill, Reedy, Aklapper, Herzi.Pinki, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to