Lucas_Werkmeister_WMDE added a comment.
> But I think the value parser is the wrong point to do this normalization anyways. We want to normalize on save, not on parse – even if someone directly creates the JSON for a commonsMedia value and submits it to the API without using `wbparsevalue`, and that JSON specifies the file name with an underscore, we still want to save it using a space, just as we do (I assume) for sitelinks. Hm, let me walk that back a bit. Sitelinks and commonsMedia values aren’t the same thing – I’m not sure if there are currently any places where we normalize data value contents. Maybe we should instead: 1. Make the value parser normalize page names. This should be a fairly straightforward change that we can make without breaking anything. 2. Make the value validator reject non-normalized page names. This would be a breaking change to the API (announce in advance, waiting period, etc.) that we would make afterwards. (“Normalize” here mainly means replacing underscores with spaces, though I could imagine some Unicode normalization as well.) TASK DETAIL https://phabricator.wikimedia.org/T251480 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Manuel, Lydia_Pintscher, Addshore, Raymond, Multichill, Reedy, Aklapper, Herzi.Pinki, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
