Nikki added a comment.
In T165870#8720589 <https://phabricator.wikimedia.org/T165870#8720589>, @Sarai-WMDE wrote: > Hey @Nikki 👋🏻 The thing is that it is generally a good practice in interface design to both use short, clear labels for actions (to improve readability) and prevent button labels from breaking into more than one line (to improve legibility). > This is why the OOUI button used here was implemented to actually keep its label from wrapping. So, improving the copy of the call to action to make it more succinct is actually the recommended and most efficient solution. Meaning: we would have to replace any copy or fix any layout that could cause the button to wrap if we let it, too. I would have thought making the page scroll horizontally has a bigger negative effect on legibility though. It seems like an issue in OOUI if it doesn't let you pick between buttons which never wrap and buttons which do, since the only reason the text is going to wrap in a situation like this (single button at the bottom of a form) is to prevent horizontal scrolling. Short labels are good, but the length will always depend on the language, font and font size. > That being said, wrapping could be a better alternative than letting the button overflow (the interface looks less broken at least). So we might use that solution as a last resort in cases when modifying the copy or the layout were impossible. I'm not sure whether we're going to run into overflow again in this particular case, but I would rather reduce the copy to "Publish" if we suspect this is going to be an issue. Here's how it looks with the button label set to the German translation of MediaWiki:Publishchanges <https://translatewiki.net/wiki/Special:Translations/MediaWiki:Publishchanges> (which is not the longest translation) and the default font size set to extra large: F36923984: de-extralarge.png <https://phabricator.wikimedia.org/F36923984> versus with the CSS I added to Wikidata's common.css: F36923989: de-extralarge-fixed.png <https://phabricator.wikimedia.org/F36923989> TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Nikki Cc: Lucas_Werkmeister_WMDE, karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thiemowmde, Lucie, Sjoerddebruin, Aklapper, Astuthiodit_1, Prufkick, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Puik, _jensen, rosalieper, xSavitar, Envlh, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Tobias1984, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
