Michael added a comment.
In T345083#9356395 <https://phabricator.wikimedia.org/T345083#9356395>, @Lucas_Werkmeister_WMDE wrote: > For implementing this, my idea would be: > > - Add a `$context` parameter to `LanguageNameLookup::getName()`, which can be one of `WikibaseContentLanguaiges::getContexts()` (`CONTEXT_TERM`, `CONTEXT_MONOLINGUAL_TEXT`, or `'term-lexicographical'`). > - Update callers to pass the right context. (In other extensions, like WikibaseLexeme and WikibaseMediaInfo, perhaps this should happen //before// the Wikibase change. Or Wikibase first makes the parameter optional. Not sure.) > - In `LanguageNameLookup::getName()`, if the context is `CONTEXT_TERM` and the language code is `mul`, return a special message instead of using `LanguageNameUtils::getLanguageName()`. For the autonym, we can probably just hard-code a string. > > @Michael does that sound okay? (I’m not yet sure if I like extending the `LanguageNameLookup` interface with that extra parameter, but I think it might be the best approach.) Mh, yeah, I think this is better than overengineering it at this point. That being said, where is EntitySchema getting its language names from? TASK DETAIL https://phabricator.wikimedia.org/T345083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Lucas_Werkmeister_WMDE, Epidosis, Amire80, Mahir256, Nikki, Lydia_Pintscher, Sarai-WMDE, ItamarWMDE, Aklapper, Manuel, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
