Michael added a comment.
In T345083#9356750 <https://phabricator.wikimedia.org/T345083#9356750>, @Lucas_Werkmeister_WMDE wrote: > Hmph, the “context” idea has a hitch: several places use `LanguageNameLookup::getName()` to get the name of a //site// language, which doesn’t really correspond to any of the existing `WikibaseContentLanguages` contexts. (`SitesModuleBase`, `SpecialItemByTitle`, and `SiteLinksView`. That’s actually more callers than the one place that gets the language name of a monolingual text language: that happens in `MonolingualHtmlFormatter` and nowhere else, AFAICT.) > > Perhaps it would be more honest to just have a boolean flag for “is this language name used for terms or not” – after all, that’s all we would use the context for, too. We can still change it to a more fine-grained context later if we really need it. I guess either that or have a `TermLanguageNameLookup` produced by the factory. But for this single problem, I think I would still go for the boolean flag. We can always refactor it later when we get an usecase that warrants it. > (By the way, at least Wikidata isn’t connected to any sites that actually have `mul` as the language, AFAICT. `metawiki`, `commonswiki` etc. are all just set to English.) Don't give people ideas 😅 TASK DETAIL https://phabricator.wikimedia.org/T345083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Michael Cc: Michael, Lucas_Werkmeister_WMDE, Epidosis, Amire80, Mahir256, Nikki, Lydia_Pintscher, Sarai-WMDE, ItamarWMDE, Aklapper, Manuel, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
