Michael added a comment.
In T345083#9356523 <https://phabricator.wikimedia.org/T345083#9356523>, @Lucas_Werkmeister_WMDE wrote: >> That being said, where is EntitySchema getting its language names from? > > Directly from `LanguageNameUtils::getLanguageName()`, I think. (Also, `LanguageNameUtils::isSupportedLanguage()` seems to be the test for whether a language is allowed or not, so `mul` wouldn’t be accepted anyways AFAICT.) Wikibase’s `LanguageNameLookup` is only used for the `LanguageFallbackIndicator` when formatting EntitySchema values using their labels. Thanks for digging that up! I guess this is another thing we need to eventually align, because, as I understand it, EntitySchema is required to have the same behavior in its Termbox as Items/Properties (aside from being for now the pilot for using the Vue Termbox on desktop). I think it was also explicitly confirmed somewhere that EntitySchema will get `mul` too (and it makes sense). But I guess by then we can just switch to using the `WikibaseRepo.LanguageNameLookupFactory` service in EntitySchema as well. TASK DETAIL https://phabricator.wikimedia.org/T345083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Lucas_Werkmeister_WMDE, Epidosis, Amire80, Mahir256, Nikki, Lydia_Pintscher, Sarai-WMDE, ItamarWMDE, Aklapper, Manuel, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
