Brion Vibber <br...@wikimedia.org> wrote:
> Unless there's some reason to do otherwise, I'd recommend dropping the
> $IP from the autogen'd LocalSettings.php and pulling in
> DefaultSettings.php from the level above. (Keeping in mind that we
> should retain compat with existing LocalSettings.php files that are
> still pulling it.)
Better, but what about /config/index.php, noMediaWikiConfig.php, validate.php
and Maintenance.php? Having only two different places where $IP is computed is
a definite improvement (assuming you fix the 4 files just mentioned), but it
still means the code in WebStart.php and Command.inc is file position
dependent. If this is the best that can be done, then that is that. However, it
would really be better if all position dependent code could be eliminated.
Dan
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
