Dan Nessett wrote: > Back in June the Selenium Framework had a local configuration file called > LocalSeleniumSettings.php. This was eliminated by Tim Starling in a 6/24 > commit with the comment that it was an insecure concept. In that commit, > new globals were added that controlled test runs. > > Last Friday, mah ripped out the globals and put the configuration > information into the execute method of RunSeleniumTests.php with the > comment "@todo Add an alternative where settings are read from an INI > file." So, it seems we have dueling developers with contrary ideas about > what is the best way to configure selenium framework tests. Should > configuration data be exposed as globals or hidden in a local > configuration file? > > Either approach works. But, by going back and forth, it makes development > of functionality for the Framework difficult. I am working on code not > yet submitted as a patch that now requires reworking because how to > reference configuration data has changed. We need a decision that decides > which of the two approaches to use.
A more neutral solution could be to provide a hook to set them. _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
