On Wed, Dec 8, 2010 at 3:11 AM, Trevor Parscal <[email protected]>wrote:
> These blank lines should not - under any circumstances - be here. But I > > do know why they are... > > Tim Starling modified the standard distribution of JSMin[1] in some good > and some bad ways. These blank lines are the result of one of these > modifications which I find to be misguided. He's basically only > compressed horizontal white-space, leaving new line characters in place. > The blank lines you see are where the comments used to be. > > I have made this point before, clearly upon deaf ears - but I will make > it again. > > * ResourceLoader has 2 modes. Production and Development (or debug) > mode. > * Production mode should be as fast as possible for users, period. > * Development mode should be as easy as possible for developers, > period. > * Any attempt to blend the two only serves to diminish the > effectiveness of either mode. > > If you want a version of the script that has not been compressed add > debug=true to the URL or set $wgResourceLoaderDebug = true; in your > LocalSettings.php. > > This particular change (the "don't delete line breaks" part of r73196) > should be reverted, Tim's good changes should be pushed upstream, and we > should be using a standard JSMin distribution whenever possible. > I think the point is that it makes bug reports that much easier to understand when they're reported by somebody who isn't in debug mode. This has to be traded off against the performance advantages of removing blank lines. Is there any data on how significant the performance improvements are? -- Andrew Garrett http://werdn.us/ _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
