This advice is all well and good, unless someone in particular actually is misguided. Glad to see people jumping on the chance to posture themselves as superior communicators - that's also really productive!
- Trevor On 12/9/10 9:28 AM, Aaron Schulz wrote: > +1 to this. Lets focus more on the changes and ideas and less on the authors. > > IMO, when I keep seeing things like "he did"/"he changed" and "[so and so] > made it so that" instead of things like "the change made" it throws up red > flags. Just discuss the change, and mention the person minimally (to help > identify the changes or get the attention of person X) or not at all. I've > also seen a lot of things like "misguided" and "bad idea" by some people. > This raises red flags too. Just discuss *what* the problems are, rather than > saying "this decision sucks". > > I've seen this pattern by more than one person. > > Tim Starling-2 wrote: >> On 08/12/10 03:11, Trevor Parscal wrote: >>> These blank lines should not - under any circumstances - be here. But I >>> >>> do know why they are... >>> >>> Tim Starling modified the standard distribution of JSMin[1] in some good >>> and some bad ways. These blank lines are the result of one of these >>> modifications which I find to be misguided. He's basically only >>> compressed horizontal white-space, leaving new line characters in place. >>> The blank lines you see are where the comments used to be. >>> >>> I have made this point before, clearly upon deaf ears - but I will make >>> it again. >> You could have just said "because Tim thought it would make debugging >> easier", and left out all the insults: "misguided", "deaf ears", etc. >> We've each given our opinions on this issue previously, the only thing >> you've added here is a dollop of incivility. >> >> Your bullying has not changed my position. I think this is a minor >> issue, and I have better things to do than to argue about it. I don't >> intend on doing any more work on JSMin for the time being. Feel free >> to make the relevant change yourself. >> >> -- Tim Starling >> >> >> _______________________________________________ >> Wikitech-l mailing list >> [email protected] >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l >> >> _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
