On 26/03/11 05:48, Daniel Friesen wrote: > What about the fixmes left open since it's not clear if anything is even > still broken currently.
If it is unclear: it either need a clarification or deserve a reversion. We already have enough lines hiding in the fog, read to jump at you when you get out of the path. > The fixmes for things like extra things like new tests should be added, > but the actual commit in question isn't broken in any way. > > The fixmes for things which are perfectly functional, but need > a minor bit of tweaking since they work perfectly find, but don't use > the best practice methods to do it. Do we even have fixmes for the last two cases? Anyway for tests, they might be required just to make sure other developers using the feature will use it as intended. There are always funny corner cases to handle, specially with PHP. -- Ashar Voultoiz _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
